Repository navigation
Fix: Draw the Windows caption buttons on the GraalVM path - #340
Merged
Merged
Conversation
The GraalVM Windows window never called dxc_native_window_configure and composed ComposeRustContent with no caption and no window actions, so the fork window took the caption strip and nothing drew the buttons. Configure the window from the app's Chrome and hand the caption and actions over, as the Kotlin/Native path does. Buttons gain a pressed fill (Fluent: Windows 11 values) and a restore glyph read from IsZoomed on both Windows paths. Closes #339
…into feat/windows-caption-buttons # Conflicts: # scripts/tests/windows-caption-metrics.test.sh
Member
Author
|
인계 메모 (pF 세션 종료, 2026-10-26). 작업 브랜치는 모두 커밋, 푸시되어 있다. 머지 규칙: 이 PR이 고친다고 하는 것을 증명하는 체크가 현재 헤드에서 초록일 때만 머지한다. 상태: CI 대기 중(Graal 캡션 버튼). v0.0.4 차단 항목. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339
Cause:
renderer/desktop/src/Win32Window.kt(GraalVM, what ships) opened the window withoutdxc_native_window_configure(the fork defaultedsystem_chrometo 0, so WM_NCCALCSIZE took the caption strip) and composedComposeRustContent(host)with noWindowCaptionand noLocalWindowActions, soWindowButtons(ComposeRustHost.kt, drawn only whencaption.height > 0and actions exist) never appeared. The Kotlin/Native mingwX64 path (renderer/windows/src/WindowsRenderer.kt) was already wired.Chrome, provides caption (32dp) andnativeWindowActions().WindowActions.maximisedstate, updated per frame from user32IsZoomedon both Windows paths (written only on change, no idle frames); maximise draws restore while maximised.CaptionStyle.pressed/closePressed; Fluent: OnSurface 12% pressed, close hover #C42B1C with white glyph, close pressed at 90%.windows-caption-metrics.test.shalso readswin32_caption.h(fork Feat: Make the X11 window the Linux default, without the Windows work (NFR-14) #172 moved the defines there).WindowsCaptionButtonsTest(glyph switch, 46x32, fills in light and dark, Restore description).Fork side: thisisthepy/compose-multiplatform-core-extended#172 (safe default, HTMAXBUTTON for Snap Layouts, pure hit test with 96/144/192 dpi tests). This PR does not depend on the pin bump to compile (only existing fork symbols plus user32
IsZoomed); Snap Layouts arrives with the pin (#336). Not compiled locally; CI builds.